HTTPStatus should be Ok even if subscription is not found. HTTPStatus is more about the HTTP communication, not about the Database status. (#19)

* Fix updateSubscription RestApi issue that prevented subscription to be updated.

* Changed name on isDuplicateSubscriptions functions to doSubscriptionExist. Fixed impacted unit test due to this change.

* Simplified updateSubscription RestApi, so SubscritionName is only specified in json file/object.

* HTTPStatus should be Ok even if subscription is not found. HTTPStatus is more about the HTTP communication, not about the Database status.

Author: tobiasake

src/main/java/com/ericsson/ei/controller/SubscriptionControllerImpl.java

@@ -69,7 +69,7 @@ public ResponseEntity<Subscription> getSubscriptionById(@PathVariable String sub
             return new ResponseEntity<Subscription>(subscription, HttpStatus.OK);
         } catch (SubscriptionNotFoundException e) {
             LOG.error("Subscription :" + subscriptionName + " not found in records");
-            return new ResponseEntity<Subscription>(subscription, HttpStatus.NOT_FOUND);
+            return new ResponseEntity<Subscription>(subscription, HttpStatus.OK);
         }
 
     }
@@ -124,7 +124,7 @@ public ResponseEntity<List<Subscription>> getSubscriptions() {
             return new ResponseEntity<List<Subscription>>(subscriptionList, HttpStatus.OK);
         } catch (SubscriptionNotFoundException e) {
             LOG.error(e.getLocalizedMessage());
-            return new ResponseEntity<List<Subscription>>(subscriptionList, HttpStatus.NOT_FOUND);
+            return new ResponseEntity<List<Subscription>>(subscriptionList, HttpStatus.OK);
         }
     }
 }

src/test/java/com/ericsson/ei/subscription/SubscriptionRestAPITest.java

@@ -124,7 +124,7 @@ public void getSubScriptionByNameNotFound() throws Exception {
 
         MvcResult result = mockMvc.perform(requestBuilder).andReturn();
 
-        assertEquals(HttpStatus.NOT_FOUND.value(), result.getResponse().getStatus());
+        assertEquals(HttpStatus.OK.value(), result.getResponse().getStatus());
         assertEquals("", result.getResponse().getContentAsString());
     }