Finish support for insert_final_newline #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuhdev
reviewed
Oct 22, 2024
xuhdev
reviewed
Oct 22, 2024
As noted in the documentation, `insert_final_newline = false` is expected to remove final newlines, but `editorconfig-mode` does not do that. Use a similar pattern to `editorconfig-set-trailing-ws` by setting a buffer-local before-save hook to remove any final newline.
vermiculus
force-pushed
the
sa/insert-final-newline-false
branch
from
601381a to
8ae8509
Compare
10sr
approved these changes
Oct 25, 2024
|
Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in the documentation,
insert_final_newline = falseis expected to remove final newlines, buteditorconfig-modedoes not do that.Use a similar pattern to
editorconfig-set-trailing-wsby setting a buffer-local before-save hook to remove any final newline.Fix #360.