-
Notifications
You must be signed in to change notification settings - Fork 25
feat: Make adding new versions easier #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HagerDakroury
wants to merge
6
commits into
main
Choose a base branch
from
dict
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9329745
feat: Make version dropdown menu dynamic
HagerDakroury fd5d508
docs: Add warning about changing stable
HagerDakroury 18acbeb
fix: Make properties format consistent
HagerDakroury 63b6a59
fix: Fix typo
HagerDakroury 1127881
fix: Rename file
HagerDakroury c120d73
fix: Fix import
HagerDakroury File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import {getCookie} from "./utils.js" | ||
| import {triggerVersion} from "./index.js" | ||
|
|
||
|
|
||
| //map of al available versions in the drodown menu,to add a version: | ||
| // 1. add all the needed info to this map where with the version as key: | ||
| //label: displayed label in the drpdown menu. | ||
| //url: url where the raw owl file is located, if missing, it will loaded from the baseUrl. | ||
| // 2. add the version to the versionsDropdown in the preferred order to display. | ||
| // Changing existing names of keys WILL break things. Like the name "stable". Please change values(label, url) only or add new values/keys. | ||
| const versionsMap = { | ||
| "stable":{label:"1.25 (stable)",url:"https://raw.githubusercontent.com/edamontology/edamontology/main/releases/EDAM_1.25.owl"}, | ||
| "1.24":{label:"1.24"}, | ||
| "1.23":{label:"1.23"}, | ||
| "latest":{label:"latest (unstable)",url:"https://raw.githubusercontent.com/edamontology/edamontology/main/EDAM_dev.owl"}, | ||
| "custom":{label:"Custom Version"} | ||
| }; | ||
|
|
||
| //order of displayed versions in the dropdown menu | ||
| const versionsDropdown = ["stable","1.24","1.23","latest","custom"] | ||
|
|
||
| const baseURL="https://raw.githubusercontent.com/edamontology/edamontology/main/releases/"; | ||
|
|
||
|
|
||
| /** | ||
| * | ||
| * @param {string} version name of the version as key in the versionsMap. | ||
| * @returns url as retrieved from the map, fallback to the baseURL or custome url. | ||
| */ | ||
| function getTreeURL(version){ | ||
| switch(version){ | ||
| case 'custom': | ||
| return getCookie("custom_url",""); | ||
| default: | ||
| if ("url" in versionsMap[version]) | ||
| return versionsMap[version]["url"]; | ||
| return baseURL+"EDAM_"+version+".owl"; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * populate the versionsMap data dynamically in the dropdown menu. | ||
| */ | ||
| function popoulateVersions(){ | ||
| var versionMenu = document.getElementById("version-menu"); | ||
| versionsDropdown.map((val)=>{ | ||
| var li = document.createElement('li'); | ||
| var a = document.createElement('a'); | ||
| a.classList.add("branch") | ||
| a.innerText=versionsMap[val]["label"]; | ||
| li.appendChild(a); | ||
| if(val =="custom") | ||
| a.addEventListener('click', function(){ | ||
| triggerVersion(); | ||
| }); | ||
|
|
||
| else | ||
| a.addEventListener('click', function(){ | ||
| browser.current_branch('edam',val); | ||
| }); | ||
| versionMenu.appendChild(li); | ||
| }); | ||
| } | ||
|
|
||
|
|
||
| export {getTreeURL,versionsDropdown,popoulateVersions} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.