Skip to content

chore: sync with ecsact_common #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1 +1 @@
7.1.1
7.1.2
13 changes: 11 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ on:
merge_group:

jobs:
typos-check:
name: Typos Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: crate-ci/typos@v1.19.0

formatting-check:
name: Formatting Check
runs-on: ubuntu-latest
Expand All @@ -17,9 +24,10 @@ jobs:
with: { clang-format-version: "18" }

test-windows:
if: github.event_name == 'merge_group'
runs-on: windows-latest
steps:
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
/Users/runneradmin/AppData/Local/bazelisk
Expand All @@ -32,9 +40,10 @@ jobs:
working-directory: test

test-linux:
if: github.event_name == 'merge_group'
runs-on: ubuntu-latest
steps:
- uses: actions/cache@v3
- uses: actions/cache@v4
with:
path: |
~/.cache/bazelisk
Expand Down
3 changes: 0 additions & 3 deletions bazel/common.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ build --enable_runfiles
build --noincompatible_remove_rule_name_parameter
query --noincompatible_remove_rule_name_parameter

# Temporary until https://github.com/grailbio/bazel-toolchain/pull/198 is merged
build:linux --extra_toolchains=@llvm_toolchain//:cc-toolchain-x86_64-linux

common:ci --announce_rc
common:ci --verbose_failures
common:ci --keep_going
Expand Down
1 change: 1 addition & 0 deletions cog.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
pre_bump_hooks = [
# Ecsact pre 1.0.0 the 0.X.0 is our 'major' version
"buildozer 'set version {{version}}' 'set compatibility_level {{version.minor}}' //MODULE.bazel:%module",
"bazel mod tidy",
]

post_bump_hooks = [
Expand Down
5 changes: 5 additions & 0 deletions typos.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[files]
extend-exclude = ["CHANGELOG.md"]

[default]
extend-ignore-re = ["(?Rm)^.*(#|//)\\s*typos:disable-line$"]
Loading