repository configuration for angular packages dev mode #2448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucas-koehler
requested changes
May 12, 2025
There was a problem hiding this comment.
Hi @dsl400 .
thanks for the contribution ❤️ !
Testing this locally, changes in the angular and core bundles were immediately recognized. This is a great improvement for development. Thanks!
I have one inline remark about the change of the Typescript version as I don't think it's required. Please have a look.
This reverts commit dec9ee1.
lucas-koehler
approved these changes
May 13, 2025
There was a problem hiding this comment.
@dsl400 Thanks for the update. I also reverted the larger lock file change that stemmed from the typescript dependency change. With this, it LGTM :)
Thanks again for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proposal of angular packages configuration that uses
ng servefor development modewhen running
npm run devinpackages/angular-materialthe packagescoreangularangular-materialandexamplesare referenced from source code and changes are applied immediately