Skip to content

ctf2: add varint test trace #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024

Conversation

vladarama
Copy link
Contributor

Adding a ctf2 varint trace to test the upcoming support of varints in TC.

This trace has been taken from the ctf2 test folder of yactfr which has a proprietary .streams format which contains the metadata and shows the expected output of decoding such a trace. This .streams file was then fed into a python script to convert it into an actual ctf2 trace with a metadata and a stream file.

Please note that this is a data test trace, therefore it does not contain non-data features
such as attributes or a preferred display integer base.

Signed-off-by: Vlad Arama vlad.arama@ericsson.com

Copy link
Contributor

@MatthewKhouzam MatthewKhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you need to declare the trace in CtfTestTrace.java

@vladarama vladarama requested a review from MatthewKhouzam May 9, 2024 14:34
PatrickTasse
PatrickTasse previously approved these changes May 9, 2024
Copy link
Contributor Author

@vladarama vladarama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go now 👍

PatrickTasse
PatrickTasse previously approved these changes May 10, 2024
Signed-off-by: Vlad Arama <vlad.arama@ericsson.com>
@MatthewKhouzam MatthewKhouzam merged commit b1cf32e into eclipse-tracecompass:master May 13, 2024
2 checks passed
@vladarama vladarama deleted the ctf-varints branch May 13, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants