Add entry-tree parameter to collapse children #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhufmann
requested changes
Jun 5, 2025
| /** | ||
| * @return The expand level. | ||
| */ | ||
| int getExpandLevel(); |
There was a problem hiding this comment.
rename to getAutoExpandLevel
| @@ -34,4 +34,9 @@ public interface TreeEntryModel { | |||
| */ | |||
| @NonNull | |||
| List<@NonNull TreeColumnHeader> getHeaders(); | |||
|
|
|||
| /** | |||
| * @return The expand level. | |||
There was a problem hiding this comment.
/**
* @return The auto-expand level
*/|
|
||
| /** | ||
| * @return The expand level. | ||
| */ |
There was a problem hiding this comment.
add before method the following schema annotation:
@Schema(description = "Sets the auto-expand level to be used for the input of the tree. The "
+ "value 0 means that there is no auto-expand; 1 means that top-level "
+ "elements are expanded, but not their children; 2 means that top-level "
+ "elements are expanded, and their children, but not grand-children; and so "
+ "on. The value -1 means that all subtrees should be expanded.")| @@ -114,4 +114,12 @@ public TreeModelWrapper(TmfTreeModel<@NonNull ITmfTreeDataModel> model) { | |||
| return fModel.getEntries(); | |||
| } | |||
|
|
|||
| /** | |||
| * Wrapper to the {@link TmfTreeModel#getExpandLevel()} method | |||
There was a problem hiding this comment.
update link regarding getAutoExpandLevel
| * | ||
| * @return Indicates till which level of the tree we should expand the nodes | ||
| */ | ||
| public int getExpandLevel() { |
|
I'm going to update this PR with my suggestions to help with this contribution. |
Merged
1 task
PatrickTasse
approved these changes
Jun 9, 2025
Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Signed-off-by: Hriday Panchasara hriday.panchasara@ericsson.com Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
bhufmann
force-pushed
the
entry-model-collpase-children
branch
from
54366b0 to
cc951e6
Compare
bhufmann
approved these changes
Jun 10, 2025
bhufmann
merged commit e99224c
into
eclipse-tracecompass-incubator:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
swagger: Add auto-expand level to TreeEntryModel
server: Add serialization of auto-expand level for tree models
tmf: Add auto-expand level in TmfTreeModel
How to test
Run updated unit tests.
Follow-ups
Related incubator PR.
#196
Review checklist
Signed-off-by: Hriday Panchasara hriday.panchasara@ericsson.com
Signed-off-by: Bernd Hufmann bernd.hufmann@ericsson.com