reports: remove log in dispose() to avoid IllegalStateException #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the Exception below. The exception is caused because during shutdown the o.e.tc.incubator.analysis.core (for reports) Activator.stop() method is called before and the plug-in is removed from the static list of activators. Remove the log statement to avoid this exception during shutdown. java.lang.IllegalStateException at org.eclipse.tracecompass.common.core.TraceCompassActivator.getInstance(TraceCompassActivator.java:86) at org.eclipse.tracecompass.incubator.internal.analysis.core.Activator.getInstance(Activator.java:43) at org.eclipse.tracecompass.incubator.analysis.core.reports.ReportsDataProviderFactory.dispose(ReportsDataProviderFactory.java:738) at org.eclipse.tracecompass.tmf.core.dataprovider.DataProviderManager.dispose(DataProviderManager.java:117) at org.eclipse.tracecompass.internal.tmf.core.Activator.stop(Activator.java:125) at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:896) at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1) ... Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
PatrickTasse
approved these changes
May 29, 2025
bhufmann
merged commit 8d2dd6f
into
eclipse-tracecompass-incubator:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This fixes the Exception below. The exception is caused because during shutdown the o.e.tc.incubator.analysis.core (for reports) Activator.stop() method is called before and the plug-in is removed from the static list of activators.
Remove the log statement to avoid this exception during shutdown.
java.lang.IllegalStateException
at org.eclipse.tracecompass.common.core.TraceCompassActivator.getInstance(TraceCompassActivator.java:86)
at org.eclipse.tracecompass.incubator.internal.analysis.core.Activator.getInstance(Activator.java:43)
at org.eclipse.tracecompass.incubator.analysis.core.reports.ReportsDataProviderFactory.dispose(ReportsDataProviderFactory.java:738)
at org.eclipse.tracecompass.tmf.core.dataprovider.DataProviderManager.dispose(DataProviderManager.java:117)
at org.eclipse.tracecompass.internal.tmf.core.Activator.stop(Activator.java:125)
at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:896)
at org.eclipse.osgi.internal.framework.BundleContextImpl$3.run(BundleContextImpl.java:1)
...
How to test
Run a unit test (e.g. OutputElementStyleSerializerTest) without and with this change, and the exception is gone with this PR.
Follow-ups
N/A
Review checklist