refactor: use communication model in AI history #15540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
sdirix
force-pushed
the
use-communication-model-in-history
branch
3 times, most recently
from
4d57aba to
4ae1f25
Compare
planger
approved these changes
May 12, 2025
There was a problem hiding this comment.
Thank you very much! This looks great to me and works very well. It is a pleasure to see this manual request recording gone! :-)
Also great work on the history view improvements. Looks good and works well. I especially like the compact and raw view. Great for debugging. I'm just not sure how useful the new-line rendering switch is. As we are just showing pretty-printed JSON, the new lines are encoded anyway, or am I misunderstanding the functionality of this switch?
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
sdirix
force-pushed
the
use-communication-model-in-history
branch
from
4ae1f25 to
a36d0a3
Compare
|
As #15409 is now merged, I updated the PR to be based on |
sdirix
force-pushed
the
use-communication-model-in-history
branch
from
a36d0a3 to
34fa80d
Compare
Refactors the AI history view to use the new AI communication model as data input. Removes the now obsolete communication recording service. The history now supports two visual modes: "raw" and "compact" for easier inspection. Also added an option to toggle newline rendering. The ai-history package now depends on ai-chat-ui instead of the other way around. Therefore the AI history is now optional. Resolves eclipse-theia#15539 Contributed on behalf of STMicroelectronics.
sdirix
force-pushed
the
use-communication-model-in-history
branch
from
34fa80d to
55d5b0b
Compare
|
@planger Can you review this today, so we can get this in until tomorrow? Changes since your last review:
|
planger
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Follow Up PR to #15409 which introduces a new generic AI communication model.
Refactors the AI history view to use the new AI communication model as
data input. Removes the now obsolete communication recording service.
The history now supports two visual modes: "raw" and "compact" for
easier inspection. Also added an option to toggle newline rendering.
Resolves #15539
How to test
Send requests and check that the AI history view shows the requests and responses. Play around with the new AI history view options: raw/compact mode and enable/disable newline rendering.
Follow-ups
Breaking changes
Attribution
Contributed by STMicroelectronics
Review checklist
Reminder for reviewers