Use editor widget as key for debug editor models #15516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#15510 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
sdirix
approved these changes
Apr 25, 2025
github-project-automation
bot
moved this from Waiting on reviewers
to Needs merge
in PR Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Uses the editor widget instead of the URI as the key for debug editor models. This recognizes the fact that multiple editors can be open for the same URI (think secondary windows, for example).
Also use the new editor widget in the case of reopening a widget from a breakpoint.
Fixes #15510
How to test
Ensure you test with the "Editor: Enable Preview" preference both on and off. Open editors, place breakpoints and invoke "Edit Breakpoint" from the gutter context menu. Make sure the editor opens correctly.
Follow-ups
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers