Skip to content

Use same autosave heuristic when closing widget #15502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Apr 23, 2025

What it does

Fixes #15501 by using the same heuristic for autosaveability when closing a widget as when deciding whether to apply autosaving.

How to test

  1. Set your autosave preference to something other than off
  2. Create an untitled editor and populate it.
  3. Attempt to close it.
  4. You should be offered the 'Change will be lost' dialog (not straight to the save location dialog).
  5. Choose any of the options, and you should get the expected behavior.

Note

If you choose to save, the newly saved version will be opened, rather than both being closed. Perhaps that should be otherwise?

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Apr 23, 2025
@JonasHelming JonasHelming requested a review from sdirix May 8, 2025 22:56
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me, however I have a comment.

@colin-grant-work colin-grant-work force-pushed the bugfix/infinite-untitled-save branch from 2b07a76 to 3077d05 Compare May 13, 2025 15:56
@colin-grant-work colin-grant-work requested a review from sdirix May 13, 2025 16:01
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog May 14, 2025
@colin-grant-work colin-grant-work merged commit c97e311 into master May 14, 2025
9 of 12 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog May 14, 2025
@colin-grant-work colin-grant-work deleted the bugfix/infinite-untitled-save branch May 14, 2025 12:41
@github-actions github-actions bot added this to the 1.62.0 milestone May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Untitled editors always saved on close when autosave is active
2 participants