Skip to content

feat(hover-service) make hover-service use platform showPopover() #15452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alexander-Taran
Copy link
Contributor

@Alexander-Taran Alexander-Taran commented Apr 12, 2025

What it does

Prevents any z-index problems for hovers/

It makes HoverService use web platform [popover='hint'].
Which it turn puts them on "top-layer"
Popover API is baseline available now and some of us use it.
https://developer.mozilla.org/en-US/docs/Web/API/Popover_API

HoverService popovers had no chance of being on top of "true" popovers.
This PR addresses just that.
Screenshot of browser-only example with this change in place:

image

Bonus: It also allows to close such popovers with "Escape"

How to test

HoverService popovers should be visible and on top of everything else.

Follow-ups

Someday when options for showPopover() will be baseline available it would be possible to position them declaratively to target. So code that calculates position could be thrown away.
It is available in chromium based browsers already.
image

Attribution

on behalf of web standards and performance

Review checklist

Reminder for reviewers

Signed-off-by: Alexander Taran <a.taran@outlook.com>
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Apr 12, 2025
@JonasHelming JonasHelming requested a review from msujew April 15, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

1 participant