Skip to content

Revert #15331 to fix webviews #15421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Apr 8, 2025

What it does

Fixes #15416

How to test

Make sure you can open webviews and webview editors and that they work correctly. I used the gitlens extensions and the drawio extension to test.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Contributed on behalf of STMicroelectronics

Review checklist

Reminder for reviewers

Fixes eclipse-theia#15416

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder requested a review from sgraband April 8, 2025 08:17
@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Apr 8, 2025
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can confirm that webviews are working again.

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Apr 8, 2025
@tsmaeder tsmaeder merged commit 668838d into eclipse-theia:master Apr 8, 2025
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Apr 8, 2025
@github-actions github-actions bot added this to the 1.61.0 milestone Apr 8, 2025
tsmaeder added a commit that referenced this pull request Apr 8, 2025
Fixes #15416

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support for custom editors looks completely broken
2 participants