Skip to content

Add 'plus' key support #15261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add 'plus' key support #15261

wants to merge 1 commit into from

Conversation

KR155E
Copy link
Contributor

@KR155E KR155E commented Mar 24, 2025

What it does

Despite being mentioned in the keymaps package's readme, the "plus" key is unavailable for key bindings. This PR adds the necessary const to support it on a German QWERTZ keyboard.

How to test

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Mar 24, 2025
@JonasHelming JonasHelming requested review from martin-fleck-at and msujew and removed request for martin-fleck-at April 1, 2025 13:56
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KR155E Can you add a How to test section? I've tried binding a command to Alt+Plus, but that didn't seem to work (I'm on QWERTZ).

@tsmaeder
Copy link
Contributor

@KR155E ping?

@KR155E
Copy link
Contributor Author

KR155E commented May 27, 2025

I am sorry, I have been unable to build Theia for a while and don't have the time to dive deeper into the problem. What I did was to hack the key constant into the bundled Theia (1.57.0) in my downstream IDE, then backport that constant. It did work in my working environment when I tried assigning simply "plus" as the keybinding for a custom command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting on reviewers
Development

Successfully merging this pull request may close these issues.

3 participants