Fix allocation of string (concatenation) during garbage collection #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bios-Marcel
force-pushed
the
remove_debug_string_alloc
branch
2 times, most recently
from
76eb17f to
6c75d8c
Compare
The code now uses the loggers format capabilities, just like other debug log-calls. Signed-off-by: Marcel Schramm <marceloschr@googlemail.com>
Bios-Marcel
force-pushed
the
remove_debug_string_alloc
branch
from
6c75d8c to
1524fe4
Compare
|
Hey ... I already contributed in the past, so I surely signed the eca! The eca site seems to be somewhat broken though? I can't access my account details or anything, I just get a weird error.
|
|
Yeah, the Eclipse website seems to have some trouble at the moment. I'll check in later and re-run the validation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code now uses the loggers format capabilities, just like other debug log-calls.
I noticed this due to the fact that we allocated roughly 1 GiB of strings during our integration tests, which run for about 30-40 seconds. Seemed quite hefty :D