Skip to content

Binary handler set from map serializer#72 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

hg-ms
Copy link
Contributor

@hg-ms hg-ms commented Sep 9, 2024

New handler enabling serialization of private java class Collections.SetFromMap.

resolves #72

@hg-ms hg-ms requested review from fh-ms and zdenek-jonas September 9, 2024 06:34
@fh-ms fh-ms added this to the 1.5 milestone Sep 9, 2024
@zdenek-jonas
Copy link
Contributor

This feature requires opening all apps with Eclipse-store. Without this:
java.lang.reflect.InaccessibleObjectException: Unable to make field final java.util.Map java.util.Collections$SetFromMap.m accessible: module java.base does not "open java.util" to unnamed module @6ab7a896

I would not merge this feature unless we can figure out how to handle this with the Java module system.

Copy link
Contributor

@zdenek-jonas zdenek-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without fix of java module system, I am not agree with merge.

Replaced XReflect with XMemory API to avoid some module system issues
Copy link
Contributor

@zdenek-jonas zdenek-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test successfull

@hg-ms hg-ms merged commit a878a19 into main Sep 9, 2024
8 checks passed
@hg-ms hg-ms deleted the BinaryHandler_SetFromMap_serializer#72 branch September 9, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Binary Handler für Collections$SetFromMap class
3 participants