Skip to content

Performance Improvement #747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Yauhenikapl
Copy link
Contributor

@Yauhenikapl Yauhenikapl commented Apr 21, 2025

Description

Performance Improvements.

Fixes #746

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes

@Yauhenikapl Yauhenikapl requested a review from atextor April 21, 2025 10:16
@Yauhenikapl
Copy link
Contributor Author

Yauhenikapl commented Apr 21, 2025

PR Achivements:

  1. Reduce time loading from 17 sec to 2 sec;
  2. Reduce Memory Allocation for 'checkUrn' method from 18gb to 1.85mb:
    BEFORE:
Screenshot 2025-04-21 at 10 43 26 AM

AFTER:
Screenshot 2025-04-24 at 9 50 23 AM

  1. Reduce Memory Allocation for URN parts object from 4gb to 2mb:
    BEFORE:
Screenshot 2025-04-21 at 12 31 53 PM

AFTER:
Screenshot 2025-04-24 at 9 51 45 AM

Total:
Time reducing: more than 85%
Memory Allocation reducing: more than 97%

CC: @atextor

@Yauhenikapl Yauhenikapl merged commit 532fdc3 into eclipse-esmf:main Apr 28, 2025
4 checks passed
@Yauhenikapl Yauhenikapl deleted the 746-improve-aspect-model-loading-performance branch April 28, 2025 10:29
Copy link

github-actions bot commented May 8, 2025

Release v2.10.3 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Improve Aspect Model Loading Performance
2 participants