Skip to content

Make ProxySelector and Authenticator optional in ProxyConfig #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Apr 10, 2025


Description

Prevent invalid use of ProxyConfig.proxySelector() if it's null

Fixes #744

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [-] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@atextor atextor merged commit a1ef21a into eclipse-esmf:main Apr 10, 2025
4 checks passed
@atextor atextor deleted the 744-fix-proxy-selector branch April 10, 2025 11:35
Copy link

github-actions bot commented May 8, 2025

Release v2.10.3 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ProxySelector/Authenticator in ProxyConfig should not be null
2 participants