Skip to content

Fix samm-cli executable jar build and integration tests #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

Fix samm-cli executable jar build and integration tests #739

merged 2 commits into from
Apr 2, 2025

Conversation

atextor
Copy link
Contributor

@atextor atextor commented Mar 31, 2025

Description

Fix samm-cli executable jar

Fixes #731

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [-] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@atextor atextor force-pushed the 731-fix-samm-cli-executable-jar branch from 07ccf75 to 7fe8a4b Compare March 31, 2025 08:31
Yauhenikapl
Yauhenikapl approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@Yauhenikapl Yauhenikapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Yauhenikapl Yauhenikapl mentioned this pull request Apr 2, 2025
Closed
9 tasks
@atextor atextor merged commit 241d4f4 into eclipse-esmf:main Apr 2, 2025
4 checks passed
@atextor atextor deleted the 731-fix-samm-cli-executable-jar branch April 2, 2025 09:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

Release v2.10.2 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yauhenikapl Yauhenikapl Yauhenikapl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] .jar Release Asset misses dependencies since 2.10.0
2 participants
@atextor @Yauhenikapl