Skip to content

Remove condition for releasing samm cli #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

michelu89
Copy link
Contributor

@michelu89 michelu89 commented Jun 17, 2024

Description

Fix release pipeline: Correctly trigger Jenkins binary signing pipeline

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Additional notes:

Add any other notes or comments here.

@michelu89 michelu89 added the bug Something isn't working label Jun 17, 2024
@michelu89 michelu89 requested a review from atextor June 17, 2024 12:49
@michelu89 michelu89 self-assigned this Jun 17, 2024
atextor added 2 commits June 17, 2024 15:09
So that Jenkins trying to push the signed .exe will always have the GH release
available to push to
@atextor atextor merged commit d463941 into eclipse-esmf:main Jun 17, 2024
4 checks passed
@atextor atextor deleted the fix/release-workflow branch June 17, 2024 14:47
Copy link

Release v2.8.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants