Skip to content

[#978] remove ClassFactory.cleanCache() in finalize method #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[#978] remove ClassFactory.cleanCache() in finalize method #1837

wants to merge 1 commit into from

Conversation

laurentschoelens
Copy link
Contributor

Fixes #978

Remove ClassFactory.cleanCache() in org.glassfish.jaxb.runtime.v2.runtime.unmarshaller.UnmarshallerImpl
Also replace ThreadLocal map in org.glassfish.jaxb.core.v2.ClassFactory with classic java.util.WeakHashMap

@laurentschoelens
Copy link
Contributor Author

@Verdent could you check this one please ? 😄

@laurentschoelens
Copy link
Contributor Author

Need to make map synchronized to be sure no pb occurs on multi threaded env

@laurentschoelens
Copy link
Contributor Author

Need to make map synchronized to be sure no pb occurs on multi threaded env

Done

@OndroMih
Copy link

Looks good. @Verdent , is it OK to merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OndroMih OndroMih OndroMih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnmarshallerImpl has an ineffective finalize() method
2 participants
@laurentschoelens @OndroMih