Skip to content

[#1830] Fix wrong name for PCData elements when using xjc in dtd mode #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

asbachb
Copy link

@asbachb asbachb commented Jun 3, 2025

see #1830 for more context

@asbachb
Copy link
Author

asbachb commented Jun 3, 2025

/cc @lukasj

@asbachb
Copy link
Author

asbachb commented Jul 16, 2025

/cc @laurentschoelens

@laurentschoelens
Copy link
Contributor

Hi @asbachb

I have to check if that won't break anything first even if you added test to prove the issue.

That will in any case break older builds when upgrade will be done : they will need update to getValue method from getvalue method in source code (I guess the setter is also concerned).

@asbachb
Copy link
Author

asbachb commented Jul 17, 2025

Hi @asbachb

I have to check if that won't break anything first even if you added test to prove the issue.

That will in any case break older builds when upgrade will be done : they will need update to getValue method from getvalue method in source code (I guess the setter is also concerned).

Thanks for having a look into. Yeah setter should be the same. I guess I should add a test for it as well. Feel free to ping me if I can do anything to get thing moving.

I guess beeing a breaking change for dtd is not that of a big deal as it's still marked as experimental.

asbachb added 2 commits July 17, 2025 23:07
…ming convetion

see eclipse-ee4j#1830

Signed-off-by: Benjamin Asbach <asbachb@users.noreply.github.com>
This will be used to generate the getter methods later on.

This fixes eclipse-ee4j#1830

Signed-off-by: Benjamin Asbach <asbachb@users.noreply.github.com>
@asbachb asbachb force-pushed the bugfix/18330-bad-method-naming-for-pcdata branch from d08c360 to a1ae2b1 Compare July 17, 2025 21:08
@asbachb asbachb changed the title Fix wrong name for PCData elements when using xjc in dtd mode [#1830] Fix wrong name for PCData elements when using xjc in dtd mode Jul 17, 2025
@asbachb
Copy link
Author

asbachb commented Jul 17, 2025

  • Rebased to latest master
  • Added test case for setValue

@laurentschoelens
Copy link
Contributor

You need to update files header with appropriate Copyright for added and modified files.
But the modifications looks good to me since com.sun.tools.xjc.reader.xmlschema.bindinfo.BIProperty#createValueProperty is working with name starting with uppercase by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants