-
Notifications
You must be signed in to change notification settings - Fork 119
Suppress episode file header comment when "-no-header" is set #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Any updates on this? Please merge and release. |
@Tomas-Kraus you were involved in a similar issue (#385) a while back, which was resolved for generated class files here. Could you please review this PR, merge it, and release the update? |
@Verdent I think this should help users for reproduicible builds with maybe backport in 2.x too (ee8) @ptziegler maybe update header with 2025 update this appropriate header (like previous last merged PR) ? PR is OK for me to be merged for what it's worth |
@ptziegler do you have also a related opened issue in this github repo ? |
846999a
to
114ede3
Compare
I've updated the copyright header and rebased onto the master, if there is still interest in this. |
@ptziegler : the copyright header should include if not working at Oracle
(Also updated my previous comments according PR author) |
114ede3
to
1ab09d4
Compare
Updated, though I'm fairly certain that the date of initial contribution must be preserved.
No, just this PR. |
This comment was marked as resolved.
This comment was marked as resolved.
The header comment generated for episode files contains a timestamp with the date of generation. This causes problems for tools that do a binary comparison of artifacts, in order to check for e.g. a required version increment. Signed-off-by: Patrick Ziegler <ziegler.patrick@hotmail.de>
1ab09d4
to
ff268b5
Compare
@pzygielo Thanks for the heads-up. I was looking for this FAQ but couldn't find it. I don't really like multiple copyright headers, so I went with the "and others" option. |
The header comment generated for episode files contains a timestamp with the date of generation. This causes problems for tools that do a binary comparison of artifacts, in order to check for e.g. a required version increment.