Skip to content

Suppress episode file header comment when "-no-header" is set #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ptziegler
Copy link

The header comment generated for episode files contains a timestamp with the date of generation. This causes problems for tools that do a binary comparison of artifacts, in order to check for e.g. a required version increment.

@alerosmile
Copy link

Any updates on this? Please merge and release.

@alerosmile
Copy link

@Tomas-Kraus you were involved in a similar issue (#385) a while back, which was resolved for generated class files here. Could you please review this PR, merge it, and release the update?

@laurentschoelens
Copy link
Contributor

laurentschoelens commented Jul 17, 2025

@Verdent I think this should help users for reproduicible builds with maybe backport in 2.x too (ee8)

@ptziegler maybe update header with 2025 update this appropriate header (like previous last merged PR) ?

PR is OK for me to be merged for what it's worth

@laurentschoelens
Copy link
Contributor

laurentschoelens commented Jul 17, 2025

@ptziegler do you have also a related opened issue in this github repo ?

@ptziegler
Copy link
Author

I've updated the copyright header and rebased onto the master, if there is still interest in this.

@laurentschoelens
Copy link
Contributor

laurentschoelens commented Jul 17, 2025

@ptziegler : the copyright header should include if not working at Oracle

# Copyright (c) 2025 Contributors to the Eclipse Foundation. All rights reserved.

(Also updated my previous comments according PR author)

@ptziegler
Copy link
Author

@laurentschoelens

@ptziegler : the copyright header should include if not working at Oracle

# Copyright (c) 2025 Contributors to the Eclipse Foundation. All rights reserved.

Updated, though I'm fairly certain that the date of initial contribution must be preserved.

@ptziegler do you have also a related opened issue in this github repo ?

No, just this PR.

@pzygielo

This comment was marked as resolved.

The header comment generated for episode files contains a timestamp with
the date of generation. This causes problems for tools that do a binary
comparison of artifacts, in order to check for e.g. a required version
increment.

Signed-off-by: Patrick Ziegler <ziegler.patrick@hotmail.de>
@ptziegler
Copy link
Author

@pzygielo Thanks for the heads-up. I was looking for this FAQ but couldn't find it. I don't really like multiple copyright headers, so I went with the "and others" option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants