feat: dsp constants refactor #5060
Open
+1,299
−1,210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolf4ood
added
enhancement
wolf4ood
force-pushed
the
feat/5059_dsp_constants_refactor
branch
from
c470b60 to
501f7d4
Compare
wolf4ood
requested review from
ndr-brt,
ronjaquensel and
juliapampus
as code owners
jimmarino
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Removes protocol specific constants from
DspConstants,HttpMessageProtocolandDspVersionsby moving those constants in each protocol specific placeDsp08Constantsindsp-spi-08Dsp2024Constantsindsp-spi-2024Dsp2025Constantsindsp-spi-2025In order to remove direct dependency with the
ProtocolVersionV_08 fromDspProtocolParserImpltheProtocolVersionRegistrynow when registering a version accept a boolean that indicates if the protocol should be considered as default. And also agetDefaultmethod has been added.The
defaultprotocol it's only needed for backward compatibility where theprotocolfield contains onlydataspace-protocol-httpwithout a version and currently it's set for v0.8.This will likely be revisited once the implementation for #5007
starts
Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5059
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.