feat: make data address handle complex properties #5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelmag110
requested review from
paullatzelsperger,
ndr-brt,
ronjaquensel and
juliapampus
as code owners
bmg13
reviewed
May 26, 2025
...ava/org/eclipse/edc/transform/transformer/edc/to/JsonObjectToDataAddressTransformerTest.java
Outdated
Show resolved
Hide resolved
spi/common/core-spi/src/main/java/org/eclipse/edc/spi/types/domain/DataAddress.java
Show resolved
Hide resolved
ndr-brt
requested changes
May 27, 2025
...ava/org/eclipse/edc/transform/transformer/edc/from/JsonObjectFromDataAddressTransformer.java
Outdated
Show resolved
Hide resolved
...ava/org/eclipse/edc/transform/transformer/edc/to/JsonObjectToDataAddressTransformerTest.java
Show resolved
Hide resolved
...ava/org/eclipse/edc/transform/transformer/edc/to/JsonObjectToDataAddressTransformerTest.java
Outdated
Show resolved
Hide resolved
...dc/protocol/dsp/transferprocess/transform/from/JsonObjectFromDataAddressTransformerTest.java
Outdated
Show resolved
Hide resolved
...dc/protocol/dsp/transferprocess/transform/from/JsonObjectFromDataAddressTransformerTest.java
Outdated
Show resolved
Hide resolved
.../eclipse/edc/connector/api/management/configuration/ManagementApiConfigurationExtension.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/edc/connector/dataplane/selector/DataPlaneSelectorClientExtension.java
Outdated
Show resolved
Hide resolved
spi/common/core-spi/src/test/java/org/eclipse/edc/spi/types/domain/DataAddressTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
May 29, 2025
...in/java/org/eclipse/edc/transform/transformer/edc/to/JsonObjectToDataAddressTransformer.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/edc/transform/transformer/edc/to/JsonObjectToDataAddressTransformer.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/edc/transform/transformer/edc/to/JsonObjectToDataAddressTransformer.java
Outdated
Show resolved
Hide resolved
jimmarino
reviewed
May 31, 2025
...dc/protocol/dsp/transferprocess/transform/from/JsonObjectFromDataAddressTransformerTest.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Jun 9, 2025
This reverts commit 1358ad4.
rafaelmag110
force-pushed
the
dataaddress_complexproperties
branch
from
a79768e to
a990e68
Compare
|
@ndr-brt Checkstyle is indeed working. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Changes
DataAddressTO and FROM transformers to allow complex attributes such as json objects or json arrays to be used.Who will sponsor this feature?
@jimmarino
@ndr-brt
Linked Issue(s)
Closes #4986