Skip to content

docs: dataspace context DR #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 12, 2025
Merged

docs: dataspace context DR #5007

merged 5 commits into from
Jun 12, 2025

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 22, 2025 •
edited
Loading

What this PR changes/adds

Provides DR for refactoring to support different dataspace contexts.

Why it does that

Briefly state why the change was necessary.

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Who will sponsor this feature?

Please @-mention the committer that will sponsor your feature.

Linked Issue(s)

Part of #5006

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@ndr-brt ndr-brt requested review from wolf4ood and a team May 22, 2025 08:52
@ndr-brt ndr-brt requested a review from juliapampus as a code owner May 22, 2025 08:52
@ndr-brt ndr-brt added the documentation Improvements or additions to documentation label May 22, 2025
@ndr-brt ndr-brt mentioned this pull request May 26, 2025
Open
@jimmarino
Copy link
Contributor

Let's discuss this with @wolf4ood and @arnoweiss.

@ndr-brt
Copy link
Member Author

ndr-brt commented May 29, 2025

@jimmarino @wolf4ood I adapted the DR as discussed yesterday. Please review.

PR #5016 is completely independent from this, I'd like to have some thoughts there as well

@ndr-brt ndr-brt changed the title docs: participant identity for dsp version docs: dataspace context DR May 29, 2025
@wolf4ood
Copy link
Contributor

@ndr-brt I think the refactor make sense anyway. Will check on this DR

jimmarino
jimmarino reviewed Jun 9, 2025
View reviewed changes
Copy link
Contributor

@jimmarino jimmarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few questions and wording suggestions. If it is easier, we can also discuss during the weekly.

@ndr-brt ndr-brt requested review from jimmarino and arnoweiss June 9, 2025 15:15
jimmarino
jimmarino approved these changes Jun 11, 2025
View reviewed changes
@ndr-brt ndr-brt merged commit 8ad147b into eclipse-edc:main Jun 12, 2025
4 checks passed
@ndr-brt ndr-brt deleted the dsp-id-dr branch June 12, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf4ood wolf4ood wolf4ood approved these changes

@jimmarino jimmarino jimmarino approved these changes

@ronjaquensel ronjaquensel ronjaquensel approved these changes

@arnoweiss arnoweiss arnoweiss approved these changes

@juliapampus juliapampus Awaiting requested review from juliapampus juliapampus is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ndr-brt @jimmarino @wolf4ood @ronjaquensel @arnoweiss