feat: make HashiCorp vault authentication extensible #4822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjaquensel
added
enhancement
ronjaquensel
force-pushed
the
vault-authentication-refactor
branch
from
1010cbf to
611b5ec
Compare
ndr-brt
reviewed
Feb 14, 2025
extensions/common/vault/hashicorp/vault-hashicorp-spi/build.gradle.kts
Outdated
Show resolved
Hide resolved
...rp/src/main/java/org/eclipse/edc/vault/hashicorp/client/HashicorpVaultTokenRenewService.java
Outdated
Show resolved
Hide resolved
...rp/src/main/java/org/eclipse/edc/vault/hashicorp/client/HashicorpVaultTokenRenewService.java
Outdated
Show resolved
Hide resolved
...a/org/eclipse/edc/vault/hashicorp/client/HashicorpVaultTokenRenewServiceIntegrationTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/eclipse/edc/vault/hashicorp/auth/HashicorpVaultAuthenticationExtension.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rp/src/main/java/org/eclipse/edc/vault/hashicorp/client/HashicorpVaultTokenRenewService.java
Fixed
Show fixed
Hide fixed
...rp/src/main/java/org/eclipse/edc/vault/hashicorp/client/HashicorpVaultTokenRenewService.java
Fixed
Show fixed
Hide fixed
ndr-brt
reviewed
Feb 21, 2025
...rc/main/java/org/eclipse/edc/vault/hashicorp/auth/HashicorpVaultAuthenticationExtension.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Feb 21, 2025
...rc/main/java/org/eclipse/edc/vault/hashicorp/auth/HashicorpVaultAuthenticationExtension.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Refactors the
vault-hashicorpmodule as outlined in this DR.Why it does that
To make vault authentication extensible and thus enable using different authentication methods.
Further notes
In addition to what's already mentioned in the DR:
HashicorpVaultTokenRenewService, which now contains the token look-up & renew methods previously located in the health service. I did not add them to theHashicorpVaultTokenRenewTaskdirectly, to keep a separation between the methods for renewing the token and the periodic task triggering the token renewal.vault-hashicorp-spi, which as of now contains only theHashicorpVaultTokenProviderinterface.HashicorpVaultSettings, as it is only used by the token provider now, and added it directly as a@Settingto the extension providing the token providerWho will sponsor this feature?
me
Linked Issue(s)
Closes #4810
Closes #4751