refactor: replace all the RetryProcess usages with RetryProcessor #4817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
wolf4ood,
jimmarino,
paullatzelsperger and
ronjaquensel
ndr-brt
force-pushed
the
4815-retry-process-usages
branch
2 times, most recently
from
0ca10ae to
514a665
Compare
jimmarino
approved these changes
Feb 12, 2025
ndr-brt
force-pushed
the
4815-retry-process-usages
branch
from
514a665 to
a0f9725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Switch all the deprecated
RetryProcessusages toRetryProcessorWhy it does that
refactor
Further notes
entityReloadreturn type toStoreResult<E>because the usage of it requires a leased entity, and theStateEntityStore.findByIdAndLeasereturns a resultWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #4815
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.