Skip to content

Alternative refactoring and fix for LLVM easyblock #3818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

Alternative refactoring and fix for LLVM easyblock #3818

wants to merge 13 commits into from

Conversation

Flamefire
Copy link
Contributor

Same as #3755 but reintroducing the restriction to LLVM < 18 to not set LIBOMPTARGET_DEVICE_ARCHITECTURES

This might have been the cause of test failures.

Flamefire added 13 commits June 30, 2025 16:44
@Flamefire
Remove super() arguments
194ef5d
@Flamefire
Introduce list_to_cmake_arg
bb67396
@Flamefire
Don't modify global variables
97d145b
@Flamefire
Rename usepolly to use_polly
2961940
@Flamefire
Don't overwrite use_polly if set
cb5c9bf
@Flamefire
Warn when using unknown CPU architecture
619e7b3
@Flamefire
Don't check for .mod files
8569ddd
@Flamefire
Refactor LLVM easyblock
4d7f071 
- Use f-Strings
- Update comments
- Use list append/extend
@Flamefire
Don't repeatedly/reduntantly construct a LooseVersion instance
bfdfd39 
`LooseVersion(self.version)` in `sanity_check_step` can be done only once.
Comparisons of a LooseVersion to a string already converts the string.
@Flamefire
Install OpenMP alias symlinks
d6a7e63
@Flamefire
Use cfg.get_cuda_cc_template_value to get CUDA CCs
2f82839
@Flamefire
Fix use of CUDA CCs in LLVM easyblock and cleanup
631bb23
@Flamefire
Set LIBOMPTARGET_DEVICE_ARCHITECTURES only for LLVM 19
5ae5722 
This was done by previous versions of the easyblock and not using the
default for LLVM 18 (which is "all", i.e. all supported CUDA CCs) might break tests.
@Flamefire Flamefire closed this Jul 2, 2025
@Flamefire Flamefire deleted the llvm-cuda-2 branch July 2, 2025 10:50
@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 2 out of 3 (3 easyconfigs in total)
n1159 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (sapphirerapids), Python 3.9.18
See https://gist.github.com/Flamefire/86912d32b4ad48139ebe2760fa2bbdb4 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire

Overview of tested easyconfigs (in order)

Build succeeded for 1 out of 3 (3 easyconfigs in total)
c51 - Linux AlmaLinux 9.4, x86_64, AMD EPYC 9334 32-Core Processor (zen4), 4 x NVIDIA NVIDIA H100, 560.35.03, Python 3.9.18
See https://gist.github.com/Flamefire/0d036a9671d02e1175ad18b8a14a0c4d for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Flamefire