-
Notifications
You must be signed in to change notification settings - Fork 295
Fix test step for CMakeNinja
easyblock by customizing test_cmd
and runtest
easyconfig parameters
#3771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This issue was revealed by multixscale/dev.eessi.io-espresso#1. Without this patch, one has to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, got any test reports coming in?
I'm a bit stuck with the next step in the contribution workflow. I managed to rebuild several |
@jngrad See https://docs.easybuild.io/integration-with-github/#github_upload_test_report That takes a bit of setting up though... Test reports are definitely welcome, but we can also take care of that to make sure these changes don't cause trouble |
@jngrad In what context were you hitting problems? It seems like you could be running into trouble due to the changes in: There's a (broader) follow-up PR to limit to impact of that change: That doesn't mean the change in here don't make sense though, but knowing which problem you were hitting exactly that triggered you to propose these changes would be helpful. edit: scratch that, this PR has nothing to do with |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 21 out of 21 (5 easyconfigs in total) |
test_cmd
and runtest
easyconfig parameters
test_cmd
and runtest
easyconfig parametersCMakeNinja
easyblock by customizing test_cmd
and runtest
easyconfig parameters
Use
ninja
instead ofmake
as the default command to run the test target in a project built by theCMakeNinja
class.