Skip to content

Fix test step for CMakeNinja easyblock by customizing test_cmd and runtest easyconfig parameters #3771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

jngrad
Copy link
Contributor

@jngrad jngrad commented Jun 12, 2025

Use ninja instead of make as the default command to run the test target in a project built by the CMakeNinja class.

@jngrad
Copy link
Contributor Author

jngrad commented Jun 12, 2025

This issue was revealed by multixscale/dev.eessi.io-espresso#1. Without this patch, one has to add test_cmd = 'ninja' to the .eb file to avoid an error message like make: *** No rule to make target 'test' when using CMakeNinja.

Copy link
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, got any test reports coming in?

@Micket Micket added the bug fix label Jun 13, 2025
@jngrad
Copy link
Contributor Author

jngrad commented Jun 13, 2025

lgtm, got any test reports coming in?

I'm a bit stuck with the next step in the contribution workflow. I managed to rebuild several CMakeNinja packages locally with --include-easyblocks-from-pr 3771. Could you please let me know which commands are used to generate a test report on this repo?

@boegel boegel added this to the next release (5.1.1?) milestone Jun 18, 2025
@boegel
Copy link
Member

boegel commented Jun 18, 2025

@jngrad See https://docs.easybuild.io/integration-with-github/#github_upload_test_report

That takes a bit of setting up though...

Test reports are definitely welcome, but we can also take care of that to make sure these changes don't cause trouble

@boegel
Copy link
Member

boegel commented Jun 18, 2025

@jngrad In what context were you hitting problems?

It seems like you could be running into trouble due to the changes in:

There's a (broader) follow-up PR to limit to impact of that change:

That doesn't mean the change in here don't make sense though, but knowing which problem you were hitting exactly that triggered you to propose these changes would be helpful.

edit: scratch that, this PR has nothing to do with Bundle, as far as I can tell.
runtest and test_cmd need to be customized due to the combination of CMakeMake and MesonNinja being used here

@boegel
Copy link
Member

boegel commented Jun 18, 2025

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS JsonCpp-1.9.5-GCCcore-13.3.0.eb
  • SUCCESS nsync-1.29.2-GCCcore-13.3.0.eb
  • SUCCESS Clang-18.1.8-GCCcore-13.3.0.eb
  • SUCCESS hiredis-1.2.0-GCCcore-13.2.0.eb
  • SUCCESS pocl-6.0-GCC-13.3.0.eb
  • SUCCESS ccache-4.9-GCCcore-13.2.0.eb
  • SUCCESS re2c-3.1-GCCcore-13.3.0.eb
  • SUCCESS double-conversion-3.3.0-GCCcore-13.3.0.eb
  • SUCCESS graphite2-1.3.14-GCCcore-13.3.0.eb
  • SUCCESS assimp-5.4.3-GCCcore-13.3.0.eb
  • SUCCESS DBus-1.15.8-GCCcore-13.3.0.eb
  • SUCCESS ffnvcodec-12.2.72.0.eb
  • SUCCESS x264-20240513-GCCcore-13.3.0.eb
  • SUCCESS NSPR-4.35-GCCcore-13.3.0.eb
  • SUCCESS NSS-3.104-GCCcore-13.3.0.eb
  • SUCCESS SDL2-2.30.6-GCCcore-13.3.0.eb
  • SUCCESS Yasm-1.3.0-GCCcore-13.3.0.eb
  • SUCCESS x265-3.6-GCCcore-13.3.0.eb
  • SUCCESS FFmpeg-7.0.2-GCCcore-13.3.0.eb
  • SUCCESS Qt6-6.7.2-GCCcore-13.3.0.eb
  • SUCCESS VTK-9.3.1-foss-2024a.eb

Build succeeded for 21 out of 21 (5 easyconfigs in total)
node3515.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/efbc395714dcb69ed1fd4556f55beb74 for a full test report.

@boegel boegel changed the title Fix CMakeNinja test command Fix test step for CMakeNinja easyblock by customizing test_cmd and runtest easyconfig parameters Jun 19, 2025
@boegel boegel merged commit f9eb157 into easybuilders:develop Jun 19, 2025
17 checks passed
@jngrad jngrad deleted the cmakeninja_test_cmd branch June 20, 2025 09:27
@boegel boegel changed the title Fix test step for CMakeNinja easyblock by customizing test_cmd and runtest easyconfig parameters Fix test step for CMakeNinja easyblock by customizing test_cmd and runtest easyconfig parameters Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants