-
Notifications
You must be signed in to change notification settings - Fork 295
enhance custom easyblock for LLVM: ensure sysroot dynamic linker is used + add ignore patterns for failing tests that can be ignored #3741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b83dff7
to
f6d7df2
Compare
Co-authored-by: ocaisa <alan.ocais@cecam.org>
Will probably also need to enforce using the proper dynamic linker also in between the projects->runtimes otherwise the ELF produced are gonna have the incorrect linker |
To discussRight now to enforce the correct It might be worth to enforce that
to the |
Just for further reference, LLVM has a section about building with a "modern" C++ toolchain: I think some parts could apply here as well, even though they're specifically talking about the LLVM binaries. |
…ong libraries in case of sysroot
Further failures in the This causes the default configuration files to be ignored SILENTLY (through an environment variable) during tests. We can probably either force setting that flag in the It should be investigated if the failures in the sanitizers for the build bot could've been related to this same problem (could've ended up not using the correct Possible downsides
https://clang.llvm.org/docs/UsersManual.html#configuration-files PS: This behavior is also used for other tests on |
Manual test report
|
@boegelbot please test @ jsc-zen3 |
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2940957477 processed Message to humans: this is just bookkeeping information for me, |
Manual test report
|
Other test report in |
I think the only thing left before we start thinking of merging this is the point in #3741 (comment) about whether we want to also enforce RPATH-linking to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Crivella I went through this in detail, and found a couple of minor (code style) things I would like to fix, see Crivella#1
With those changes included, this should be good to go, I'll put it through another extensive testing round...
minor tweaks to LLVM easyblock
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
This reverts commit 079e0e1.
@boegelbot please test @ jsc-zen3 |
@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... - notification for comment with ID 2949916545 processed Message to humans: this is just bookkeeping information for me, |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) edit: this was on top of EESSI-extend in EESSI version 2023.06 |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 0 out of 1 (1 easyconfigs in total) |
This PR changes the following in the LLVM EasyBlock behavior:
sysroot
buildoption is set will now attempt to find a dynamic linker under that path (by globbing forsysroot/**/ld-*.so*'
) that is a real file and not a link-Wl,-dynamic-linker
option pointing to the found pathfull_llvm
build and with. IfGCCcore
is defined but not in theLIBRARY_PATH
add a-L/path/to/gcccore/libs
option to the config file. This is needed as some tests will fail for not finding GCCcore core libraries likegcc_s
during compilation. Is this too aggressive?This is a fix for:
--sysroot
if specified #3740