Skip to content

remove references to python 2 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions gitup/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,9 @@
# Copyright (C) 2011-2018 Ben Kurtovic <ben.kurtovic@gmail.com>
# Released under the terms of the MIT License. See LICENSE for details.

from __future__ import print_function

import argparse
import os
import platform
import sys

from colorama import init as color_init, Style

Expand All @@ -17,11 +14,6 @@
delete_bookmarks, list_bookmarks, clean_bookmarks)
from gitup.update import update_bookmarks, update_directories, run_command

def _decode(path):
"""Decode the given string using the system's filesystem encoding."""
if sys.version_info.major > 2:
return path
return path.decode(sys.getfilesystemencoding())

def _build_parser():
"""Build and return the argument parser."""
Expand All @@ -39,7 +31,7 @@ def _build_parser():
group_m = parser.add_argument_group("miscellaneous")

group_u.add_argument(
'directories_to_update', nargs="*", metavar="path", type=_decode,
'directories_to_update', nargs="*", metavar="path",
help="""update this repository, or all repositories it contains
(if not a repo directly)""")
group_u.add_argument(
Expand All @@ -60,11 +52,9 @@ def _build_parser():
remote-tracking branches that no longer exist on their remote""")

group_b.add_argument(
'-a', '--add', dest="bookmarks_to_add", nargs="+", metavar="path",
type=_decode, help="add directory(s) as bookmarks")
'-a', '--add', dest="bookmarks_to_add", nargs="+", metavar="path", help="add directory(s) as bookmarks")
group_b.add_argument(
'-d', '--delete', dest="bookmarks_to_del", nargs="+", metavar="path",
type=_decode,
help="delete bookmark(s) (leaves actual directories alone)")
group_b.add_argument(
'-l', '--list', dest="list_bookmarks", action="store_true",
Expand All @@ -73,7 +63,7 @@ def _build_parser():
'-n', '--clean', '--cleanup', dest="clean_bookmarks",
action="store_true", help="delete any bookmarks that don't exist")
group_b.add_argument(
'-b', '--bookmark-file', nargs="?", metavar="path", type=_decode,
'-b', '--bookmark-file', nargs="?", metavar="path",
help="use a specific bookmark config file (default: {0})".format(
get_default_config_path()))

Expand Down
2 changes: 0 additions & 2 deletions gitup/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# Copyright (C) 2011-2018 Ben Kurtovic <ben.kurtovic@gmail.com>
# Released under the terms of the MIT License. See LICENSE for details.

from __future__ import print_function

from glob import glob
import os

Expand Down
13 changes: 3 additions & 10 deletions gitup/migrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,7 @@

import os

try:
from configparser import ConfigParser, NoSectionError
PY3K = True
except ImportError: # Python 2
from ConfigParser import SafeConfigParser as ConfigParser, NoSectionError
PY3K = False
from configparser import ConfigParser, NoSectionError

__all__ = ["run_migrations"]

Expand All @@ -37,16 +32,14 @@ def _migrate_old_format():
if not os.path.exists(old_path):
return

config = ConfigParser(delimiters="=") if PY3K else ConfigParser()
config = ConfigParser(delimiters="=")
config.optionxform = lambda opt: opt
config.read(old_path)

try:
bookmarks = [path for path, _ in config.items("bookmarks")]
bookmarks = [path.encode("utf8") for path, _ in config.items("bookmarks")]
except NoSectionError:
bookmarks = []
if PY3K:
bookmarks = [path.encode("utf8") for path in bookmarks]

new_path = os.path.join(os.path.split(old_path)[0], "bookmarks")
os.rename(old_path, new_path)
Expand Down
2 changes: 0 additions & 2 deletions gitup/test/test_bookmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# Copyright (C) 2011-2018 Ben Kurtovic <ben.kurtovic@gmail.com>
# Released under the terms of the MIT License. See LICENSE for details.

from __future__ import print_function, unicode_literals

from gitup import config

def test_empty_list(tmpdir, capsys):
Expand Down
2 changes: 0 additions & 2 deletions gitup/test/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
# Copyright (C) 2011-2018 Ben Kurtovic <ben.kurtovic@gmail.com>
# Released under the terms of the MIT License. See LICENSE for details.

from __future__ import print_function, unicode_literals

import platform
import subprocess
import sys
Expand Down
7 changes: 4 additions & 3 deletions gitup/update.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@
#
# Copyright (C) 2011-2018 Ben Kurtovic <ben.kurtovic@gmail.com>
# Released under the terms of the MIT License. See LICENSE for details.

from __future__ import print_function

import logging
from glob import glob
import os
import re
Expand All @@ -14,6 +12,8 @@
from git import RemoteReference as RemoteRef, Repo, exc
from git.util import RemoteProgress

logger = logging.getLogger(__name__)

__all__ = ["update_bookmarks", "update_directories", "run_command"]

BOLD = Style.BRIGHT
Expand Down Expand Up @@ -126,6 +126,7 @@ def _update_branch(repo, branch, is_active=False):
try:
base = repo.git.merge_base(branch.commit, upstream.commit)
except exc.GitCommandError as err:
logger.debug(err)
print(YELLOW + "skipped:", "can't find merge base with upstream.")
return

Expand Down
13 changes: 5 additions & 8 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@

from setuptools import setup, find_packages

if sys.hexversion < 0x02070000:
exit("Please upgrade to Python 2.7 or greater: <https://www.python.org/>.")

from gitup import __version__

with open('README.md') as fp:
Expand Down Expand Up @@ -39,12 +36,12 @@
"Operating System :: POSIX",
"Operating System :: Microsoft :: Windows",
"Programming Language :: Python",
"Programming Language :: Python :: 2.7",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.4",
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Software Development :: Version Control :: Git"
]
)