Introduce redirect_storage
#1386
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new Storage instance executes an http GET on a URL passed. It expects
the response to be a redirect to the URL of a destination target
dataset. After the destination is resolved, it behaves as a storage
appropiate for the target url.
- It follows up to 10 redirects until one matches one of the handled
protocols
- Currently it handles the following protocols:
- s3
- gs or gcs
- http+icechunk, http+ic, https+icechunk, or https+ic
- r2
- tigris
- The redirect for s3 must include a region as query argument, example:
`Location: s3://foo/bar/baz?region=us-east-1`
- The redirect for r2 must include an account as query argument, example:
`Location: r2://foo/bar/baz?account_id=12345`
- Currently the target Storage instances are created using anonymous
credentials
- Currently no auth is supported in the redirection service
Collaborator
Author
|
This is missing documentation, left for a followup PR. |
Collaborator
Author
|
Probably the best way to understand how to use this is to look at the new python test, after reading the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new Storage instance executes an http GET on a URL passed. It expects the response to be a redirect to the URL of a destination target dataset. After the destination is resolved, it behaves as a storage appropiate for the target url.
Location: s3://foo/bar/baz?region=us-east-1Location: r2://foo/bar/baz?account_id=12345