-
-
Notifications
You must be signed in to change notification settings - Fork 42
feat(mixins): add mixins #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@mnboos This is amazing, well done. But is there a written test for this feature? |
Thank you! No,.not yet. I thought I will do this, if you basically liked it. Which seems to be the case. So, shall I write tests and docs for it? I guess I shall. 😁 |
Coverage: ___________________________________ coverage: platform linux, python 3.12.8-final-0 ____________________________________
Name Stmts Miss Cover Missing
--------------------------------------------------------------------------------
...
ninja_extra/mixins/__init__.py 174 0 100%
...
--------------------------------------------------------------------------------
TOTAL 2990 56 98%
========================================== 454 passed, 87 warnings in 12.26s =========================================== |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 98.01% 98.15% +0.14%
==========================================
Files 68 69 +1
Lines 2770 2987 +217
==========================================
+ Hits 2715 2932 +217
Misses 55 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is the PR with the mixin-functionality as shown in #278