Skip to content

feat(mixins): add mixins #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat(mixins): add mixins #279

wants to merge 10 commits into from

Conversation

mnboos
Copy link

@mnboos mnboos commented Jun 24, 2025

This is the PR with the mixin-functionality as shown in #278

@mnboos mnboos mentioned this pull request Jun 24, 2025
@eadwinCode
Copy link
Owner

@mnboos This is amazing, well done. But is there a written test for this feature?

@mnboos
Copy link
Author

mnboos commented Jun 29, 2025

Thank you!

No,.not yet. I thought I will do this, if you basically liked it. Which seems to be the case. So, shall I write tests and docs for it? I guess I shall. 😁

@mnboos
Copy link
Author

mnboos commented Jul 1, 2025

I added tests and docs.

Coverage:

___________________________________ coverage: platform linux, python 3.12.8-final-0 ____________________________________

Name                                               Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------
...
ninja_extra/mixins/__init__.py                       174      0   100%
...
--------------------------------------------------------------------------------
TOTAL                                               2990     56    98%
========================================== 454 passed, 87 warnings in 12.26s ===========================================

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (6a592c1) to head (64cd298).
Report is 9 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   98.01%   98.15%   +0.14%     
==========================================
  Files          68       69       +1     
  Lines        2770     2987     +217     
==========================================
+ Hits         2715     2932     +217     
  Misses         55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants