-
-
Notifications
You must be signed in to change notification settings - Fork 40
Using apaginate_queryset when the paginator is AsyncPaginationBase #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using apaginate_queryset when the paginator is AsyncPaginationBase #264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
==========================================
- Coverage 99.45% 98.01% -1.44%
==========================================
Files 56 68 +12
Lines 2552 2770 +218
==========================================
+ Hits 2538 2715 +177
- Misses 14 55 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
64c8353
to
9207cc5
Compare
Fix and updated |
9207cc5
to
bfa8cba
Compare
I rebased, @eadwinCode could you try to trigger CI actions again |
Thanks for working on this @Aidan79225 |
@eadwinCode It seems django isn't supported async orm before version-4.2, I updated with a commit for this cases |
Yes, thats correct |
This diff introduces support for both synchronous and asynchronous pagination in the PaginatorOperation class in the ninja_extra/pagination/operations.py file. The key changes include:
Import Updates:
Paginator Type Update:
Asynchronous Pagination Logic:
apaginate_queryset
method is used.These changes enable the PaginatorOperation class to handle both synchronous and asynchronous pagination seamlessly, improving flexibility for developers using the library.