-
-
Notifications
You must be signed in to change notification settings - Fork 5
options default to empty Objects #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before documents.read and documents.parseLocal would fail when no options were passed.
Thanks to @DrRataplan for bringing this up and suggesting the solution, too. |
Nice! This error really puzzled me! |
Interestingly, one test fails but only in Existdb 7:
|
Yes, this change happened upstream (in exist 7) as part of an effort to store XML declarations as part of the original data. These stored declarations will now overrule the default serialisation settings. |
🎉 This PR is included in version 5.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This fixes some hard to understand errors when utilising some node-exist functions: