Skip to content

Do not use CTRL+C to close the app, only use quit/exit #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 22, 2025

Conversation

depink5
Copy link
Contributor

@depink5 depink5 commented May 20, 2025

This PR avoids using CTRL+C in fastddsspy to close the application.

Merge after:

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.17%. Comparing base (2f19b0c) to head (e1003b8).

Files with missing lines Patch % Lines
cpp_utils/src/cpp/event/StdinEventHandler.cpp 14.28% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   62.37%   62.17%   -0.21%     
==========================================
  Files          65       65              
  Lines        1858     1864       +6     
  Branches      534      535       +1     
==========================================
  Hits         1159     1159              
- Misses        379      384       +5     
- Partials      320      321       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@depink5 depink5 changed the base branch from main to feature/fix/command-history May 20, 2025 13:43
@depink5 depink5 force-pushed the feature/use-quit-command-to-exit branch from a4f3b37 to f243ccd Compare May 20, 2025 14:46
Copy link

@Carlosespicur Carlosespicur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Waiting for CI.

Carlosespicur
Carlosespicur previously approved these changes May 21, 2025
@rsanchez15 rsanchez15 dismissed Carlosespicur’s stale review May 21, 2025 06:30

Test with DDS Router and DDS Recorder tools first

@rsanchez15 rsanchez15 requested a review from Carlosespicur May 21, 2025 06:30
Copy link
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base automatically changed from feature/fix/command-history to main May 21, 2025 07:37
depink5 added 5 commits May 21, 2025 10:03
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
@depink5 depink5 force-pushed the feature/use-quit-command-to-exit branch from f243ccd to e1003b8 Compare May 21, 2025 08:04
@depink5
Copy link
Contributor Author

depink5 commented May 21, 2025

@rsanchez15 rsanchez15 merged commit 46cda1b into main May 22, 2025
17 checks passed
@rsanchez15 rsanchez15 deleted the feature/use-quit-command-to-exit branch May 22, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants