-
Notifications
You must be signed in to change notification settings - Fork 8
Do not use CTRL+C to close the app, only use quit/exit #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 62.37% 62.17% -0.21%
==========================================
Files 65 65
Lines 1858 1864 +6
Branches 534 535 +1
==========================================
Hits 1159 1159
- Misses 379 384 +5
- Partials 320 321 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4f3b37
to
f243ccd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for CI.
Test with DDS Router and DDS Recorder tools first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this section in docs
https://fast-dds-spy.readthedocs.io/en/latest/rst/user_manual/tool.html#close-application
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
Signed-off-by: Denisa <denisa@eprosima.com>
f243ccd
to
e1003b8
Compare
This PR avoids using CTRL+C in fastddsspy to close the application.
Merge after: