Skip to content

[23169] Documentation for the optional serialization of WireProtocolConfigQos #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

[23169] Documentation for the optional serialization of WireProtocolConfigQos #1068

merged 3 commits into from
May 21, 2025

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented May 14, 2025 •
edited
Loading

Description

This PR adds the proper documentation for the related feature.

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@Mario-DL
Refs #23169: Add docs
c66212f 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v3.2.3 milestone May 14, 2025
@Mario-DL Mario-DL mentioned this pull request May 14, 2025
Closed
12 tasks
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima May 14, 2025 09:07
@Mario-DL
Refs #23169: Doc monitor service proxy optional qos
1525cbd 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima May 14, 2025 12:39
cferreiragonz
cferreiragonz requested changes May 19, 2025
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note or paragraph on monitor_service_configuration.rst explaining that monitor service will serialize the optional QoS even if they are not configured in the main participant?

@Mario-DL
Copy link
Member Author

monitor_service_configuration

I will add it to the monitor_service_topics.rst

@Mario-DL
Refs #23169: Apply Carlo's review
25d382e 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL requested review from cferreiragonz and removed request for cferreiragonz May 20, 2025 08:06
cferreiragonz
cferreiragonz approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@cferreiragonz cferreiragonz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cferreiragonz cferreiragonz added implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS and removed ci-pending labels May 20, 2025
@Mario-DL Mario-DL mentioned this pull request May 20, 2025
Merged
12 tasks
@Mario-DL Mario-DL merged commit 913de2f into master May 21, 2025
4 checks passed
@Mario-DL Mario-DL deleted the feature/23169 branch May 21, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees
No one assigned
Labels
implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS
Projects
None yet
Milestone
v3.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @cferreiragonz