[23031] Add RPC Client/Server examples documentation #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Carlosespicur
force-pushed
the
feature/rpc/interfaces
branch
from
0189ddb to
e90ff12
Compare
12 tasks
Carlosespicur
force-pushed
the
feature/rpc/interfaces
branch
from
396eabc to
ae2aee1
Compare
Carlosespicur
requested review from
rsanchez15
and removed request for
rsanchez15
rsanchez15
requested changes
May 21, 2025
There was a problem hiding this comment.
General comments or out of this PR:
- Remove the indentation in the code-block of this example (also for requester and replier): https://eprosima-fast-rtps--1064.org.readthedocs.build/en/1064/fastdds/rpc_dds/request_reply_api/rpc_service.html#example
- Update RPC image (https://eprosima-fast-rtps--1064.org.readthedocs.build/en/1064/fastdds/rpc_dds/rpc_dds_intro.html)
- In that section, add a complete description of rpc streamin, or feed operations. This should point to the RPC with Feed tutorial.
Carlosespicur
force-pushed
the
feature/rpc/interfaces
branch
2 times, most recently
from
0f44c43 to
c1f88e5
Compare
rsanchez15
requested changes
May 23, 2025
Carlosespicur
requested review from
rsanchez15
and removed request for
rsanchez15
7 tasks
Carlosespicur
force-pushed
the
feature/rpc/interfaces
branch
from
f6dbae8 to
8cbd105
Compare
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…thod and PENDING status Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
… api docs Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
…ection Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Signed-off-by: Carlosespicur <carlosespicur@proton.me>
Carlosespicur
force-pushed
the
feature/rpc/interfaces
branch
from
8cbd105 to
4d430ec
Compare
Carlosespicur
requested review from
rsanchez15
and removed request for
rsanchez15
rsanchez15
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds he documentation related to RPC over DDS examples and interfaces. It also refactors RPC over DDS section and adds some tests for the provided examples.
Contributor Checklist
Reviewer Checklist