Skip to content

[23094] Escape folder separator in generated CMakeLists.txt (backport #466) #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 4.0.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 5, 2025

Description

Fixes a bug in Windows when generating CMakeLists.txt

@Mergifyio backport 4.0.x 3.3.x 2.5.x 2.1.x (not sure if all, only those supporting relative dir generation)

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

    • Affects only Windows, where we currently have no CI
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

This is an automatic backport of pull request #466 done by [Mergify](https://mergify.com).

* Refs #23041. Simplify direct conversions.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23041. Escape paths converting backward slashes into forward ones.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23041. Apply changes to `SwigCMake.stg`.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

* Refs #23041. Escape swig interface file.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>

---------

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit 9bc63a8)
@MiguelCompany MiguelCompany requested a review from richiprosima May 5, 2025 14:46
@github-actions github-actions bot added the ci-pending PR which CI is running label May 5, 2025
@MiguelCompany MiguelCompany added this to the v4.0.5 milestone May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant