-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add support of typescript #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add typescript support
Would love to see this merged! Thanks for your work :) It seems like the maintainers of this library are busy working on bug fixes. You could consider adding this to DefinitelyTyped! While waiting for types to be added, I forked your repo and installed it in my project(s) with NOTE: I had to move |
@R1D3R175 |
I think if you add "types" to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, thank you so much @umidjon-2231 ! Sorry there's been radio silence for the past several months, I haven't had loads of time for this project. I really appreciate this contribution, will add the types to package.json too.
🎉 This PR is included in version 0.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you for the kind words! I really appreciate the opportunity to contribute here. Excited to see the project moving forward again, and glad the types will be added to package.json 🙌 |
This pull request introduces TypeScript definitions (
type.d.ts
) forhtml2pdf.js
, allowing developers to use the library with improved type safety and better IDE support.Changes Included:
type.d.ts
) with comprehensive type definitions for the library.Html2PdfOptions
,Html2PdfWorker
, andHtml2PdfStatic
.Motivation & Benefits:
html2pdf.js
with type checking.How to Test:
Looking forward to feedback and suggestions!