-
Notifications
You must be signed in to change notification settings - Fork 70
feat(table): added frozen header, frozen column, permanent scrollbars #2464
Conversation
🦋 Changeset detectedLatest commit: cc37971 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…into 2457-table-iteration-3
agliga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bill-min
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the freeze-column count feels a bit weird to me. Unless we have usage that ppl are using skin standalone and building bare foot table without wrapping it with component, I think it would be more flexible just add class to tr > td,th and ebayui/table will expose column count then apply to each tr > td,th.
Our strategy is typically to lean on static implementation of features without requiring major work from external libraries, and the smallest footprint to accomplish the goal. This makes it more optimal.
BTW, the column freezing is not a column count like you see on typical spreadsheets. It freezes only a specific column to avoid the table being unusable in smaller screens. |
Fixes #2457
Description
Added the next set of features to
table:Notes
For the permanent scrollbars, I created a utility mixin to be used by a public utility class as well as intrinsically for
tablewithout the use of the utility class.Screenshots
Checklist