Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Conversation

@ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Oct 9, 2024

Fixes #2457

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added the next set of features to table:

  • added frozen header
  • added full height table modifier
  • added frozen column
  • added full height table override
  • added permanent scrollbars

Notes

For the permanent scrollbars, I created a utility mixin to be used by a public utility class as well as intrinsically for table without the use of the utility class.

Screenshots

image

image

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Oct 9, 2024
@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2024

🦋 Changeset detected

Latest commit: cc37971

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArtBlue ArtBlue requested review from agliga and bill-min October 17, 2024 17:16
Copy link

@bill-min bill-min left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the freeze-column count feels a bit weird to me. Unless we have usage that ppl are using skin standalone and building bare foot table without wrapping it with component, I think it would be more flexible just add class to tr > td,th and ebayui/table will expose column count then apply to each tr > td,th.

@ArtBlue
Copy link
Contributor Author

ArtBlue commented Oct 18, 2024

LGTM, just the freeze-column count feels a bit weird to me. Unless we have usage that ppl are using skin standalone and building bare foot table without wrapping it with component, I think it would be more flexible just add class to tr > td,th and ebayui/table will expose column count then apply to each tr > td,th.

Our strategy is typically to lean on static implementation of features without requiring major work from external libraries, and the smallest footprint to accomplish the goal. This makes it more optimal.

  1. It allows the css module to work anywhere. Since we are an open-source library, we always want to lean on that.
  2. It is far less brittle. If a user forgets to add the the marker to any td or th, the table will break.
  3. It is more efficient as fewer changes/updates need to be made on fewer elements.

BTW, the column freezing is not a column count like you see on typical spreadsheets. It freezes only a specific column to avoid the table being unusable in smaller screens.

@ArtBlue ArtBlue merged commit 32b6d59 into 18.4.0 Oct 18, 2024
@ArtBlue ArtBlue deleted the 2457-table-iteration-3 branch October 18, 2024 13:09
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants