Prepare cli auth & access token retrieval for api key hashing #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h route & remove api key generation there
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dobrac
requested changes
May 15, 2025
|
|
||
| if (!team || !selectedTeam) return | ||
|
|
||
| await fetch('/api/team/state', { |
There was a problem hiding this comment.
won't this fetch cause UI unresponsiveness (meaning delay after click)?
There was a problem hiding this comment.
lgtm, but this only changes cookies which means no matter the outcome, latency will be ~20 ms. the cookies kind of have to be set before doing the push/refresh, which is why we await. the router.push already has some delay in this scenario, so we don't compromise on "non-instant" navigation here anyways at the moment.
dobrac
approved these changes
May 15, 2025
ben-fornefeld
deleted the
change-the-dashboard-authcli-endpoint-to-always-generate-new-e2b-1581
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be prepared for our upcoming migration to hashed api keys, this pr introduces the following changes:
dashboard/account/auth/cli, since it is not required in the cliAdditionally but not entangled, it adds route for manual team selection cookie updates, to fix changing teams on a non team dependent route (e.g
/dashboard/account)