Skip to content

Improve auth callback logging #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Improve auth callback logging #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
584c720
improve: auth callback logging
ben-fornefeld May 15, 2025
946153b
improve: don't manually redirect on exchange error, just log
ben-fornefeld May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/app/api/auth/callback/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { createClient } from '@/lib/clients/supabase/server'
import { redirect } from 'next/navigation'
import { PROTECTED_URLS } from '@/configs/urls'
import { AUTH_URLS, PROTECTED_URLS } from '@/configs/urls'
import { logError, logInfo } from '@/lib/clients/logger'
import { ERROR_CODES } from '@/configs/logs'

export async function GET(request: Request) {
// The `/auth/callback` route is required for the server-side auth flow implemented
Expand All @@ -13,21 +15,31 @@ export async function GET(request: Request) {
const returnTo = requestUrl.searchParams.get('returnTo')?.toString()
const redirectTo = requestUrl.searchParams.get('redirect_to')?.toString()

console.log('Auth callback:', {
logInfo('Auth callback:', {
code: !!code,
origin,
returnTo,
})

if (code) {
const supabase = await createClient()
await supabase.auth.exchangeCodeForSession(code)
const { data, error } = await supabase.auth.exchangeCodeForSession(code)

if (error) {
logError(
ERROR_CODES.SUPABASE,
'Error exchanging code for session:',
error
)
} else {
logInfo('OTP was successfully exchanged for user:', data.user.id)
}
}

if (redirectTo) {
const returnToUrl = new URL(redirectTo, origin)
if (returnToUrl.origin === origin) {
console.log('Redirecting to:', redirectTo)
logInfo('Redirecting to:', redirectTo)
return redirect(redirectTo)
}
}
Expand All @@ -37,12 +49,12 @@ export async function GET(request: Request) {
// Ensure returnTo is a relative URL to prevent open redirect vulnerabilities
const returnToUrl = new URL(returnTo, origin)
if (returnToUrl.origin === origin) {
console.log('Returning to:', returnTo)
logInfo('Returning to:', returnTo)
return redirect(returnTo)
}
}

// Default redirect to dashboard
console.log('Redirecting to dashboard')
logInfo('Redirecting to dashboard')
return redirect(PROTECTED_URLS.DASHBOARD)
}
7 changes: 7 additions & 0 deletions src/lib/clients/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ export const logDebug = (...args: Parameters<typeof console.debug>) => {
)
}

export const logInfo = (...args: Parameters<typeof console.info>) => {
console.info(
ansis.bgGray.black(' INFO '),
ansis.gray(args.map(stringifyArg).join(' '))
)
}

export const logSuccess = (...args: Parameters<typeof console.log>) => {
console.log(
ansis.bgGreenBright.white(' SUCCESS '),
Expand Down