Skip to content

Fix client side sandbox id construction #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2025

Conversation

ben-fornefeld
Copy link
Member

@ben-fornefeld ben-fornefeld commented May 7, 2025

The infra sends sandboxID and clientID which need to be constructed client side to get the correct sandbox id usable for users. This pr fixes this issue. Also it improves the UX by increasing the min column size, for users to see the full id by default.

@ben-fornefeld ben-fornefeld self-assigned this May 7, 2025
@ben-fornefeld ben-fornefeld added the bug Something isn't working label May 7, 2025
Copy link

linear bot commented May 7, 2025

Copy link

vercel bot commented May 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 6:23pm
web-juliett ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 6:23pm

@jakubno jakubno merged commit c707ee7 into main May 7, 2025
4 checks passed
@jakubno jakubno deleted the fix-client-side-sandbox-id-construction-e2b-2181 branch May 7, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants