Improve ux for default "email" team names #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult team name user experience in the ui + render accordingly in team selector
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mlejva
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently default teams for users get the email of the owner assigned as the name. We had reports that this confused people. To make default team appearances more user friendly, we will transform default "unchanged" team names as follows in the ui:
ben.fornefeld@gmail.com->Ben.fornefeld's TeamThis is done by appending
transformed_default_nameattribute to theClientTeamtype, when a team has a default "unchanged" team name, in thegetUserTeamsserver function.To further clear up confusion, when navigating to
/team, default transformed team names receive a hint "Seen as - Ben Fornefeld's Team" under the team name settings.Also this pr: