Remove ai-agents middleware rewrite #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ben-fornefeld
added
improvement
mishushakov
requested changes
Apr 25, 2025
|
@mishushakov the way you suggested makes it slightly annoying to configure. remember when using js native regexp, for every literal |
…figurability + improve: readability
|
refactored to glob pattern matching for easier configurability |
mishushakov
reviewed
Apr 25, 2025
Comment on lines
+1
to
+14
| /** | ||
| * Configuration for SEO-related settings. | ||
| */ | ||
|
|
||
| /** | ||
| * An array of glob patterns for deprecated routes that will return a 410 (Gone) status. | ||
| * | ||
| * Pattern syntax examples: | ||
| * - '/ai-agents' - Exact match for /ai-agents | ||
| * - '/ai-agents/*' - Matches a single segment (e.g., /ai-agents/foo) | ||
| * - '/ai-agents/**' - Matches multiple segments (e.g., /ai-agents/foo/bar) | ||
| * - '/ai-agents/{foo,bar}' - Matches /ai-agents/foo or /ai-agents/bar | ||
| * - '/ai-agents/!(foo|bar)' - Matches anything except /ai-agents/foo or /ai-agents/bar | ||
| */ |
There was a problem hiding this comment.
remove comments, I think the code is self-explanatory
There was a problem hiding this comment.
it's not. if i just want to configure new paths and don't know anything about the repo this is helpful
mishushakov
reviewed
Apr 25, 2025
Comment on lines
+14
to
+17
| const normalizedPath = | ||
| pathname.endsWith('/') && pathname !== '/' | ||
| ? pathname.slice(0, -1) // Remove trailing slash except for root path | ||
| : pathname |
There was a problem hiding this comment.
do you actually need to normalize it?
mishushakov
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes references to our framer landing page by removing
LANDING_PAGE_FRAMER_DOMAINfrom global/rewrite config and sitemap generation.Additionally:
seoconfig for marking path globs as deprecated routes to inform seo crawlers about deprecation to get them removed from indexing faster by returning410(no content) status codes instead of404in catch-all route handler/ai-agents/**paths to return410