Linting workflow for Python and JavaScript. #745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help ensure code quality by checking Python and JavaScript code on pull requests. Here's a summary of the changes: - For Python, I'm using Ruff. - You can find Ruff's configuration in `packages/python-sdk/pyproject.toml`. - I've applied initial auto-fixes, which brought down the error count from 653 to 367. We can tackle the remaining errors later. - The workflow will check the `packages/python-sdk/` directory. - For JavaScript, I'm using Biome. - Biome's configuration is in `biome.json` at the root of the project. - The workflow will use Biome to check for errors in the `packages/js-sdk/` directory. - I've applied initial auto-fixes (including some that were potentially unsafe), reducing errors in `packages/js-sdk/` from over 90 to 22. We can address the remaining errors in subsequent steps. - I've disabled Biome's formatter to avoid any conflicts with Prettier. For now, these linters will report errors but won't necessarily block pull requests for all remaining issues. This allows us to improve the codebase incrementally.
|
|
Jules is failing me 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help ensure code quality by checking Python and JavaScript code on pull requests.
Here's a summary of the changes:
For Python, I'm using Ruff.
packages/python-sdk/pyproject.toml.packages/python-sdk/directory.For JavaScript, I'm using Biome.
biome.jsonat the root of the project.packages/js-sdk/directory.packages/js-sdk/from over 90 to 22. We can address the remaining errors in subsequent steps.For now, these linters will report errors but won't necessarily block pull requests for all remaining issues. This allows us to improve the codebase incrementally.