-
Notifications
You must be signed in to change notification settings - Fork 45
Feat: basic support for bitucket #650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should start applying Hexagonal architecture (Ports and Adapters) from now on
…ncatenated string
username?: string; | ||
display_name: string; | ||
nickname?: string; | ||
links: { avatar: { href: "https://bitbucket.org/account/open-listings/avatar/" } }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZibanPirate careful about link to avatar. It does not look like static.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were asked in #648. Since we added the Open-listings project #649 from Bitbucket, it makes sense to now support at least some basic endpoints from Bitbucket.
Bitbucket.getRepository
to get general repo infoBitbucket.listRepositoryContributors
you can test this on stage: