chore: re-writing ./web using RSPack and tailwind
#591
Conversation
| } | ||
|
|
||
| const routes: RouteInterface[] = [ | ||
| let routes: Array< |
There was a problem hiding this comment.
we are mutating few lines down
There was a problem hiding this comment.
Still in javascript an array can be mutable even if it is const, unless you force the TS compiler with as const at the end so it will not throw a compilation error.
I'd also argue why should we mutate the path? why not having just on immutable path per each page?
There was a problem hiding this comment.
i see your point, i guess i could loop thorough it using forEach instead of .map, i will fix it in another PR ...
it's down to code styling, i wouldn't be too strict on that
| </Helmet> | ||
| <Stack direction="vertical" min={{ height: "100vh" }}> | ||
| <Navbar | ||
| <div className="flex flex-col min-h-screen"> |
There was a problem hiding this comment.
Another reason why I don't like tailwind
There was a problem hiding this comment.
?? elaborate cuz i don't see an issue here
There was a problem hiding this comment.
I can foresee even longer class names in the future (even if it does have a cool vs code extension for autocompletion)
There was a problem hiding this comment.
These values can be stored as json files.
Why? because it can be useful to leverage other platforms like Localise to handle translation updates
ZibanPirate
added
enhancement
web:
@dzcode.io/uiwith tailwind (using daisyui).mobile:
./mobilefrom mono repo (from both npm and lerna)api:
Type of change